Metacello#390 cache and undo the undefinedSymbols handling while runn…

…ing Metacello tests that remove classes from the system during cleanup or the tests themselves ... should see significant speedup --- for GemStone --- will have to work out platform independent scheme if this trick pays off ...
dalehenrich · Jul 6, 2016 · 2f4a29b · 2f4a29b
1 parent 8ea339b
commit 2f4a29b
Show file tree

Hide file tree

Showing 14 changed files with 49 additions and 31 deletions.
diff --git a/...itory/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/instance/setUp.st b/...itory/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/instance/setUp.st
@@ -15,4 +15,7 @@ setUp
   self tempRepositories add: repo.
   Smalltalk at: #'Metacello_Configuration_Test_Repository' put: repo.
   initialWorkingCopyList := MCWorkingCopy allManagers
-    collect: [ :each | each packageName ]
+    collect: [ :each | each packageName ].
+  undefinedSymbols := UserGlobals at: #'UndefinedSymbols'.
+  UserGlobals removeKey: #'UndefinedSymbols'.
+  UndefinedSymbolList removeFirst
diff --git a/...ry/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/instance/tearDown.st b/...ry/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/instance/tearDown.st
@@ -22,4 +22,6 @@ tearDown
         cr;
         show:
             'leaked package from ' , self printString , ' -> ' , leak printString ].
-  self assert: diff isEmpty
+  self assert: diff isEmpty.
+  UserGlobals at: #'UndefinedSymbols' put: undefinedSymbols.
+  UndefinedSymbolList addLast: undefinedSymbols
diff --git a/...y/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/methodProperties.json b/...y/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/methodProperties.json
@@ -12,7 +12,7 @@
 		"project" : "dkh 6/12/2012 15:41:23.319",
 		"projectWith:" : "dkh 6/12/2012 15:41:23.319",
 		"runCase" : "ChristopheDemarey 4/29/2013 16:22",
-		"setUp" : "dkh 10/16/2014 09:55",
-		"tearDown" : "dkh 10/18/2014 09:27",
+		"setUp" : "dkh 07/06/2016 14:10",
+		"tearDown" : "dkh 07/06/2016 14:10",
 		"tearDownPackages:" : "dkh 6/12/2012 15:41:23.319",
 		"tempRepositories" : "dkh 6/12/2012 15:41:23.319" } }
diff --git a/repository/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/properties.json b/repository/Metacello-TestsMC.package/MetacelloDictionaryRepositoryTest.class/properties.json
@@ -7,7 +7,8 @@
 	"commentStamp" : "",
 	"instvars" : [
 		"tempRepositories",
-		"initialWorkingCopyList" ],
+		"initialWorkingCopyList",
+		"undefinedSymbols" ],
 	"name" : "MetacelloDictionaryRepositoryTest",
 	"pools" : [
 		 ],

diff --git a/repository/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/instance/setUp.st b/repository/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/instance/setUp.st
@@ -7,4 +7,7 @@ setUp
   self setUpRepositoryContents.
   MetacelloProjectRegistration resetRegistry.
   initialWorkingCopyList := MCWorkingCopy allManagers
-    collect: [ :each | each packageName ]
+    collect: [ :each | each packageName ].
+  undefinedSymbols := UserGlobals at: #'UndefinedSymbols'.
+  UserGlobals removeKey: #'UndefinedSymbols'.
+  UndefinedSymbolList removeFirst
diff --git a/...tory/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/instance/tearDown.st b/...tory/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/instance/tearDown.st
@@ -14,4 +14,6 @@ tearDown
         cr;
         show:
             'leaked package from ' , self printString , ' -> ' , leak printString ].
-  self assert: diff isEmpty
+  self assert: diff isEmpty.
+  UserGlobals at: #'UndefinedSymbols' put: undefinedSymbols.
+  UndefinedSymbolList addLast: undefinedSymbols
diff --git a/...ory/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/methodProperties.json b/...ory/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/methodProperties.json
@@ -6,10 +6,10 @@
 		"doSilently" : "dkh 09/25/2015 16:28",
 		"hasPackage:" : "dkh 09/25/2015 16:28",
 		"runCase" : "dkh 09/25/2015 16:28",
-		"setUp" : "dkh 09/25/2015 16:28",
+		"setUp" : "dkh 07/06/2016 13:53",
 		"setUpRepositories" : "dkh 09/25/2015 16:28",
 		"setUpRepositoryContents" : "dkh 09/25/2015 16:28",
-		"tearDown" : "dkh 09/25/2015 16:28",
+		"tearDown" : "dkh 07/06/2016 14:05",
 		"tearDownPackageList" : "dkh 09/25/2015 16:28",
 		"tearDownPackages" : "dkh 09/25/2015 16:28",
 		"tearDownRepositories" : "dkh 09/25/2015 16:28",

diff --git a/repository/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/properties.json b/repository/Metacello-TestsMC.package/MetacelloScriptingStdTstHarness.class/properties.json
@@ -4,9 +4,10 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "dkh 09/25/2015 16:28",
+	"commentStamp" : "",
 	"instvars" : [
 		"registry",
+		"undefinedSymbols",
 		"monticelloRepository",
 		"configurationRepository",
 		"initialWorkingCopyList" ],

diff --git a/repository/Metacello-TestsMC.package/monticello.meta/version b/repository/Metacello-TestsMC.package/monticello.meta/version
diff --git a/...tory/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/instance/setUp.st b/...tory/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/instance/setUp.st
@@ -1,17 +1,20 @@
 running
 setUp
-	| repo |
-	super setUp.
-	MetacelloConfigurationResource projectAttributes: nil.
-	repo := self monticelloRepository.
-	gofer := Gofer new.
-	gofer disablePackageCache.
-	gofer repository: repo.
-	Smalltalk at: #'Metacello_Gofer_Test_Repository' put: repo.
-	repo := self configurationRepository.
-	gofer repository: repo.
-	Smalltalk at: #'Metacello_Configuration_Test_Repository' put: repo.
-	gofer package: 'MetacelloTestConfigurationOfProjectToolBox'.
-	gofer metacelloLoad.
-	Smalltalk at: #'Metacello_Configuration_Test_DoIt_Result' put: false.
-	Smalltalk at: #'Metacello_Configuration_Test_POST_DoIt_Result' put: false.
+  | repo |
+  super setUp.
+  MetacelloConfigurationResource projectAttributes: nil.
+  repo := self monticelloRepository.
+  gofer := Gofer new.
+  gofer disablePackageCache.
+  gofer repository: repo.
+  Smalltalk at: #'Metacello_Gofer_Test_Repository' put: repo.
+  repo := self configurationRepository.
+  gofer repository: repo.
+  Smalltalk at: #'Metacello_Configuration_Test_Repository' put: repo.
+  gofer package: 'MetacelloTestConfigurationOfProjectToolBox'.
+  gofer metacelloLoad.
+  Smalltalk at: #'Metacello_Configuration_Test_DoIt_Result' put: false.
+  Smalltalk at: #'Metacello_Configuration_Test_POST_DoIt_Result' put: false.
+  undefinedSymbols := UserGlobals at: #'UndefinedSymbols'.
+  UserGlobals removeKey: #'UndefinedSymbols'.
+  UndefinedSymbolList removeFirst
diff --git a/...y/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/instance/tearDown.st b/...y/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/instance/tearDown.st
@@ -22,4 +22,6 @@ tearDown
     ifAbsent: [  ].
   Smalltalk
     removeKey: #'Metacello_Configuration_Test_POST_DoIt_Result'
-    ifAbsent: [  ]
+    ifAbsent: [  ].
+  UserGlobals at: #'UndefinedSymbols' put: undefinedSymbols.
+  UndefinedSymbolList addLast: undefinedSymbols
diff --git a/.../Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/methodProperties.json b/.../Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/methodProperties.json
@@ -7,8 +7,8 @@
 		"monticelloRepository" : "dkh 6/12/2012 15:41:23.319",
 		"projectWith:" : "dkh 6/12/2012 15:41:23.319",
 		"runCase" : "ChristopheDemarey 4/29/2013 16:22",
-		"setUp" : "dkh 6/12/2012 15:41:23.319",
-		"tearDown" : "dkh 10/18/2014 09:26",
+		"setUp" : "dkh 07/06/2016 14:04",
+		"tearDown" : "dkh 07/06/2016 14:05",
 		"testNestedForDoOrder1" : "dkh 6/12/2012 15:41:23.319",
 		"testNestedForDoOrder2" : "dkh 6/12/2012 15:41:23.319",
 		"testNestedForDoOrder3" : "dkh 6/12/2012 15:41:23.319",

diff --git a/...sitory/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/properties.json b/...sitory/Metacello-TestsMCA.package/MetacelloConfigAPIToolBoxTestCase.class/properties.json
@@ -6,7 +6,8 @@
 		 ],
 	"commentStamp" : "",
 	"instvars" : [
-		"gofer" ],
+		"gofer",
+		"undefinedSymbols" ],
 	"name" : "MetacelloConfigAPIToolBoxTestCase",
 	"pools" : [
 		 ],

diff --git a/repository/Metacello-TestsMCA.package/monticello.meta/version b/repository/Metacello-TestsMCA.package/monticello.meta/version