From f68dcaabfc0be734e4598d1a706e8e35eeede1ff Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Fri, 9 Sep 2016 15:54:57 -0700 Subject: [PATCH] turn on debugger source pane ... fireworks at the moment --- ...Selected.listElement.selectedIndex.shiftPressed..st | 10 +++++++++- .../TDRemoteDebugger.class/methodProperties.json | 2 +- .../instance/clientSourceElement.st | 4 ---- .../methodProperties.json | 2 +- .../monticello.meta/version | 2 +- 5 files changed, 12 insertions(+), 8 deletions(-) diff --git a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/instance/itemSelected.listElement.selectedIndex.shiftPressed..st b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/instance/itemSelected.listElement.selectedIndex.shiftPressed..st index 573980511..351478a3c 100644 --- a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/instance/itemSelected.listElement.selectedIndex.shiftPressed..st +++ b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/instance/itemSelected.listElement.selectedIndex.shiftPressed..st @@ -1,6 +1,6 @@ tools itemSelected: miniTool listElement: listElement selectedIndex: index shiftPressed: shiftPressed - | currentFrame enabled disabled contextEditorSpec contextClientElement | + | currentFrame enabled disabled contextEditorSpec contextClientElement sourceEditorSpec sourceClientElement | theMiniTool := miniTool. index = 0 ifTrue: [ ^ false ]. @@ -9,6 +9,10 @@ itemSelected: miniTool listElement: listElement selectedIndex: index shiftPresse self homeMethodOop: currentFrame homeMethodOop; receiverOop: currentFrame frameSelfOop. + sourceEditorSpec := (TDEditorSpec topez: self topez editorAspect: #'source') + parentObject: listElement parent; + windowId: sourceWindowId; + yourself. contextEditorSpec := (TDEditorSpec topez: self topez editorAspect: #'contents') parentObject: listElement parent; windowId: contextWindowId; @@ -19,6 +23,7 @@ itemSelected: miniTool listElement: listElement selectedIndex: index shiftPresse ifFalse: [ enabled := {} ]. ^ sourceWindowId ifNil: [ + sourceWindowId := currentFrame editUsing: sourceEditorSpec. contextWindowId := currentFrame editUsing: contextEditorSpec. self objectSerializer toString: @@ -29,6 +34,7 @@ itemSelected: miniTool listElement: listElement selectedIndex: index shiftPresse #'refreshList'. nil} ] ifNotNil: [ + sourceClientElement := currentFrame clientElementUsing: sourceEditorSpec. contextClientElement := currentFrame clientElementUsing: contextEditorSpec. self objectSerializer toString: @@ -37,6 +43,8 @@ itemSelected: miniTool listElement: listElement selectedIndex: index shiftPresse #'clearMenuCategories:'. disabled. #'editStonElement:'. + sourceClientElement. + #'editStonElement:'. contextClientElement. #'setList:'. (self frameList)} ] \ No newline at end of file diff --git a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/methodProperties.json b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/methodProperties.json index 71008408c..33a266dfb 100644 --- a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/methodProperties.json +++ b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteDebugger.class/methodProperties.json @@ -9,7 +9,7 @@ "frameList" : "dkh 09/08/2016 16:43", "homeMethodOop" : "dkh 09/08/2016 16:44", "homeMethodOop:" : "dkh 09/08/2016 16:44", - "itemSelected:listElement:selectedIndex:shiftPressed:" : "dkh 09/09/2016 10:34", + "itemSelected:listElement:selectedIndex:shiftPressed:" : "dkh 09/09/2016 15:50", "printOn:" : "dkh 09/09/2016 12:08", "receiverOop" : "dkh 09/08/2016 14:22", "receiverOop:" : "dkh 09/08/2016 14:22", diff --git a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/instance/clientSourceElement.st b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/instance/clientSourceElement.st index 18c989c7e..704033566 100644 --- a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/instance/clientSourceElement.st +++ b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/instance/clientSourceElement.st @@ -2,8 +2,4 @@ as yet unclassified clientSourceElement ^ super clientSourceElement inClassOop: self inClassOop; - sourceRange: self sourceRange; - allInstVarNames: self allInstVarNames; - allClassVarNames: self allClassVarNames; - allSharedPoolNames: self allSharedPoolNames; yourself \ No newline at end of file diff --git a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/methodProperties.json b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/methodProperties.json index f6b417016..fcac0b2ff 100644 --- a/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/methodProperties.json +++ b/repository/Topez-GemStone-Server-33x-Core.package/TDRemoteStackFrameMethodElementBuilder.class/methodProperties.json @@ -2,7 +2,7 @@ "class" : { }, "instance" : { - "clientSourceElement" : "dkh 09/09/2016 10:22", + "clientSourceElement" : "dkh 09/09/2016 15:53", "defaultEditorWindowLocation" : "dkh 09/09/2016 10:14", "defaultEditorWindowName" : "dkh 09/09/2016 10:14", "differentMethodCreated:" : "dkh 09/09/2016 10:14", diff --git a/repository/Topez-GemStone-Server-33x-Core.package/monticello.meta/version b/repository/Topez-GemStone-Server-33x-Core.package/monticello.meta/version index cea47f149..2454b980f 100644 --- a/repository/Topez-GemStone-Server-33x-Core.package/monticello.meta/version +++ b/repository/Topez-GemStone-Server-33x-Core.package/monticello.meta/version @@ -1 +1 @@ -(name 'Topez-GemStone-Server-33x-Core-dkh.24' message 'forgot to add hanlding for specials values (synthetic fields)' id '8cd2d678-3b8d-4c91-a8d3-5a4f8a447fd6' date '09/09/2016' time '15:03:51' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.23' message 'more progress on context inspector ...' id '1f33b9ba-df35-4026-91c3-7e631f89805a' date '09/09/2016' time '14:50:37' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.22' message 'TDRemoteStackFrame>>dotSelfObject properyly defined' id '72d58b15-ec78-4552-b5fa-7f298e12cb67' date '09/09/2016' time '13:48:30' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.21' message 'remote inspector is working well enough ...' id '2a6985f1-cd83-40bd-942d-a5bc24bdfec1' date '09/09/2016' time '13:33:17' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.20' message 'fiddle about' id '19e60fc9-9286-4239-90f5-a3c0ebc20c2d' date '09/09/2016' time '11:44:58' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.19' message 'continue remote inspector work' id '4d88008b-6ffe-46b9-bc04-52a4d9e3bea4' date '09/09/2016' time '11:29:07' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.18' message 'full court press for remote context inspector' id 'c42f7d4a-971e-494c-88bb-7822f91da593' date '09/09/2016' time '10:55:57' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.17' message 'start work on getting source pane (later) and context inspector panes implemented' id '0c6d8e07-51f8-44cd-84bb-839c79264534' date '09/09/2016' time '10:37:47' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.16' message 'remote debugger is working again ... after a fashion' id '224332a2-446b-409c-82c1-2de442cb50a0' date '09/09/2016' time '07:06:42' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.15' message 'hook up TDRemoteFrameContents' id '2e36fb65-8a99-4813-804c-018adc044ff8' date '09/09/2016' time '07:04:45' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.14' message 'Thanks to Richard''s cool idea to create a dictionary in the context of the server session that has all the state needed for a remote frame, I''ve got the debugger stack view up and running ... not seeing source and seeing the remote frame inspector which is not what I expected, but we''re in good shape now ...' id '5d5328bc-302f-42ef-9d8f-6449126c4cd2' date '09/08/2016' time '17:13:21' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.13' message 'tantalizingly close to opening debugger ...' id 'a5fc7d40-448c-48b3-be49-7e67e8ff0fa2' date '09/08/2016' time '14:29:06' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.12' message 'moving forward with remote debugger implementation' id 'ef0064df-52fb-4d52-82ac-17d9f1c2313c' date '09/08/2016' time '06:54:22' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.11' message 'introduce TDRemoteDebugger' id 'f3764474-ad35-4537-9b73-4bddf5228818' date '09/07/2016' time '20:12:56' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.10' message 'fix debugger sourceOffset calculation for 3.4 ... looks like it should be valid for 3.1.x as well? Start playing with remote debugging of GemStone sessions (3.3.x only)' id '134f59a8-641d-4d78-9820-4998454e8421' date '09/07/2016' time '18:47:52' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.9' message 'clean up portability issues for the new `cpu command`' id 'adc8c029-eb88-4af2-a3c2-eee320f820cb' date '07/11/2016' time '10:42:17' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.8' message 'add `cpu` command for measuring elapsed cpu time in milliseconds ... add --computeInterval option to `pf start` command ' id '31a539ac-f7c8-49b1-9d96-14705f20d71f' date '07/10/2016' time '12:37:04' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.7' message 'improve the Smalltalk API for `pf start` and `pf view`' id '067a0330-6f89-4909-91c4-a2a6d27ee4ec' date '07/06/2016' time '12:20:08' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.6' message 'update `pf start` man page for 3.3' id '46244593-a6b4-403f-aa71-ae37b47ae256' date '02/26/2016' time '14:18:46' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.5' message 'Pushing things around for the object creation view ... sort by tally and sort by tally class ... want to display total object count as well as object count by class in summary view and then when viewing callers/senders stack get a chance to switch to a different class ... the ProfMon provides separate call stacks segregated by class ..' id '48f77969-a4d2-4933-b935-cee1e3f45ef4' date '07/03/2015' time '16:09:44' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.4' message 'add objCreation option for `pf` command ... not quite done as I may want to add an object creation report to the browser' id '8028a7bb-6528-4850-921a-f4f22c8ab988' date '06/30/2015' time '16:47:48' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.3' message 'final round of format tweaks ... will wait for new traceObjetCreation api for further `pf` work' id 'f05689b9-f847-4f00-9b3a-ba635b3bd963' date '06/12/2015' time '11:34:18' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.2' message 'checkpoint ... fiddle formatting to accomodate edenUsage' id 'df82f41b-c3b0-4cc0-9b0a-dbb78dad57bd' date '06/11/2015' time '16:47:10' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.1' message 'support the new profiling features in GemStone 3.3: - new package and tool class (TDProfileTool33 - implement smalltalk api in TDProfileTool - add options to selected TDProfileTool commands - intial implementation of new 3.3 features' id '17fd889d-7cda-4404-be13-1a68b5ea3203' date '06/11/2015' time '10:06:20' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ()) \ No newline at end of file +(name 'Topez-GemStone-Server-33x-Core-dkh.25' message 'turn on debugger source pane ... fireworks at the moment' id 'e089c9ee-8a68-4164-8b31-8af011509b24' date '09/09/2016' time '15:54:56' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.24' message 'forgot to add hanlding for specials values (synthetic fields)' id '8cd2d678-3b8d-4c91-a8d3-5a4f8a447fd6' date '09/09/2016' time '15:03:51' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.23' message 'more progress on context inspector ...' id '1f33b9ba-df35-4026-91c3-7e631f89805a' date '09/09/2016' time '14:50:37' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.22' message 'TDRemoteStackFrame>>dotSelfObject properyly defined' id '72d58b15-ec78-4552-b5fa-7f298e12cb67' date '09/09/2016' time '13:48:30' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.21' message 'remote inspector is working well enough ...' id '2a6985f1-cd83-40bd-942d-a5bc24bdfec1' date '09/09/2016' time '13:33:17' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.20' message 'fiddle about' id '19e60fc9-9286-4239-90f5-a3c0ebc20c2d' date '09/09/2016' time '11:44:58' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.19' message 'continue remote inspector work' id '4d88008b-6ffe-46b9-bc04-52a4d9e3bea4' date '09/09/2016' time '11:29:07' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.18' message 'full court press for remote context inspector' id 'c42f7d4a-971e-494c-88bb-7822f91da593' date '09/09/2016' time '10:55:57' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.17' message 'start work on getting source pane (later) and context inspector panes implemented' id '0c6d8e07-51f8-44cd-84bb-839c79264534' date '09/09/2016' time '10:37:47' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.16' message 'remote debugger is working again ... after a fashion' id '224332a2-446b-409c-82c1-2de442cb50a0' date '09/09/2016' time '07:06:42' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.15' message 'hook up TDRemoteFrameContents' id '2e36fb65-8a99-4813-804c-018adc044ff8' date '09/09/2016' time '07:04:45' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.14' message 'Thanks to Richard''s cool idea to create a dictionary in the context of the server session that has all the state needed for a remote frame, I''ve got the debugger stack view up and running ... not seeing source and seeing the remote frame inspector which is not what I expected, but we''re in good shape now ...' id '5d5328bc-302f-42ef-9d8f-6449126c4cd2' date '09/08/2016' time '17:13:21' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.13' message 'tantalizingly close to opening debugger ...' id 'a5fc7d40-448c-48b3-be49-7e67e8ff0fa2' date '09/08/2016' time '14:29:06' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.12' message 'moving forward with remote debugger implementation' id 'ef0064df-52fb-4d52-82ac-17d9f1c2313c' date '09/08/2016' time '06:54:22' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.11' message 'introduce TDRemoteDebugger' id 'f3764474-ad35-4537-9b73-4bddf5228818' date '09/07/2016' time '20:12:56' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.10' message 'fix debugger sourceOffset calculation for 3.4 ... looks like it should be valid for 3.1.x as well? Start playing with remote debugging of GemStone sessions (3.3.x only)' id '134f59a8-641d-4d78-9820-4998454e8421' date '09/07/2016' time '18:47:52' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.9' message 'clean up portability issues for the new `cpu command`' id 'adc8c029-eb88-4af2-a3c2-eee320f820cb' date '07/11/2016' time '10:42:17' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.8' message 'add `cpu` command for measuring elapsed cpu time in milliseconds ... add --computeInterval option to `pf start` command ' id '31a539ac-f7c8-49b1-9d96-14705f20d71f' date '07/10/2016' time '12:37:04' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.7' message 'improve the Smalltalk API for `pf start` and `pf view`' id '067a0330-6f89-4909-91c4-a2a6d27ee4ec' date '07/06/2016' time '12:20:08' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.6' message 'update `pf start` man page for 3.3' id '46244593-a6b4-403f-aa71-ae37b47ae256' date '02/26/2016' time '14:18:46' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.5' message 'Pushing things around for the object creation view ... sort by tally and sort by tally class ... want to display total object count as well as object count by class in summary view and then when viewing callers/senders stack get a chance to switch to a different class ... the ProfMon provides separate call stacks segregated by class ..' id '48f77969-a4d2-4933-b935-cee1e3f45ef4' date '07/03/2015' time '16:09:44' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.4' message 'add objCreation option for `pf` command ... not quite done as I may want to add an object creation report to the browser' id '8028a7bb-6528-4850-921a-f4f22c8ab988' date '06/30/2015' time '16:47:48' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.3' message 'final round of format tweaks ... will wait for new traceObjetCreation api for further `pf` work' id 'f05689b9-f847-4f00-9b3a-ba635b3bd963' date '06/12/2015' time '11:34:18' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.2' message 'checkpoint ... fiddle formatting to accomodate edenUsage' id 'df82f41b-c3b0-4cc0-9b0a-dbb78dad57bd' date '06/11/2015' time '16:47:10' author 'dkh' ancestors ((name 'Topez-GemStone-Server-33x-Core-dkh.1' message 'support the new profiling features in GemStone 3.3: - new package and tool class (TDProfileTool33 - implement smalltalk api in TDProfileTool - add options to selected TDProfileTool commands - intial implementation of new 3.3 features' id '17fd889d-7cda-4404-be13-1a68b5ea3203' date '06/11/2015' time '10:06:20' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ()) \ No newline at end of file