Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cache hit ratio to reflect change since last snap #273

Merged
merged 1 commit into from Jun 10, 2022

Conversation

blogh
Copy link
Collaborator

@blogh blogh commented Jan 20, 2022

This fixes #272

@blogh
Copy link
Collaborator Author

blogh commented Jan 20, 2022

@Krysztophe : can you try this ?

@Krysztophe
Copy link
Contributor

As said in private:

with a pgbench scale 1000 (about the size of the 12 Gb share buffers), after a server restart, I get immediately a hit ratio around 65%-90%, although only a very small part of the tables are in the SB (checked with pg_buffercache) ?!?

@blogh
Copy link
Collaborator Author

blogh commented Jun 10, 2022

I tried with scale 300 (4GB) and the default shared buffers (128MB).
I got similar results.
But I also see the same with hit_ratio service of check_pgactivity.

@blogh blogh force-pushed the cache_hit_ratio branch 4 times, most recently from 92e91aa to f074d9d Compare June 10, 2022 09:36
pgactivity/data.py Outdated Show resolved Hide resolved
pgactivity/views.py Show resolved Hide resolved
docs/man/pg_activity.pod Outdated Show resolved Hide resolved
@blogh
Copy link
Collaborator Author

blogh commented Jun 10, 2022

I have regened the man file and squashed the commits.

Copy link
Member

@dlax dlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blogh blogh merged commit 5600706 into dalibo:master Jun 10, 2022
@blogh blogh deleted the cache_hit_ratio branch September 16, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hit ratio is not an instantaneous metric
3 participants