Enable -Weverything warnings and add optional active_message field#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Weverything, with a curated set of-Wno-*opt-outs inphaser/copts.bzlfor non-actionable diagnostics (C++ back-compat, padding, vtable emission, intentional offset/size conversions, etc.). Third-party headers are treated as system headers via--features=external_include_paths.UnionInfo::binary_size, potential-UBshift-negative-value/undefined-reinterpret-cast, deprecated implicit copy ops onMessage/Field, plus extra-semi, unused params/functions, ignored[[nodiscard]], missing initializers, and ~20 nested-scope shadow renames in tests.std::any active_messagefield to generated message types, enabled viaphaser_library(enable_active_message = True)or theactive_message=trueplugin command-line option. Off by default (no change to existing output).Test plan
bazel test //...(6 targets) passes-Weverythingrecompile is warning-clean//phaser:active_message_testverifies the field defaults empty, holds a payload, and resets#include <any>andstd::any active_message;only when enabled