Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WebSocketClient protocol for mocking #311

Closed
wants to merge 5 commits into from

Conversation

euskadi31
Copy link
Contributor

No description provided.

@euskadi31
Copy link
Contributor Author

up

@daltoniam
Copy link
Owner

Sorry about the delay in responding. I have been going back and forth on this. I get the usefulness for mocking in creating the WebSocketClient protocol, but it does add a little bit of complexity just for the sake of mocking. I'm kinda of indecisive on if that is a trade off worth making. Not to drag this out any longer, but let me get some feedback from some folk. Thank you for your patience in my indecision 😄.

@BenjaminPrieur
Copy link

up

@hishnash
Copy link
Contributor

@daltoniam Im currently working on a branch that moves the connection logic out of the main WebSocket class into a dedicated class. The idea being users can switch in and out that connection class if needed to support things like custom proxies etc and taking over of existing connections. Maybe we could merge this concept of mocking into that in that there is a dedicated connection class that is set up for mocking that would not pollute the main code base.

@daltoniam
Copy link
Owner

I did some refactor work for Swift 4 (version 3.0.0) and add this in. Sorry it took so long to get in, but all joy now 😄. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants