Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLog MDLC + NDLC when NLog ver. 4.6 is ready #181

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@snakefoot
Copy link
Contributor

snakefoot commented Sep 6, 2018

NLog 4.6 includes better handling of non-string-objects: NLog/NLog#2857

There might be a catch22 when having multiple libraries that are using LibLog and only some are using 5.0.3.Then use of OpenMdc will behave different during transition phase of upgrading all libraries. But MDLC is the "future". One can avoid the catch22 by not upgrading the main application to NLog 4.6 until all libraries are updated (If they actually make use of OpenMdc, which seems rare)

@damianh damianh merged commit e86f5e4 into damianh:master Nov 8, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@damianh

This comment has been minimized.

Copy link
Owner

damianh commented Nov 8, 2018

Thanks for PR @snakefoot ! I see nlog 4.6 is not shipped yet. This is safe to ship before 4.6 is out?

@damianh damianh added the enhancement label Nov 8, 2018

@damianh damianh added this to the v5.0.3 milestone Nov 8, 2018

@damianh

This comment has been minimized.

Copy link
Owner

damianh commented Nov 8, 2018

@snakefoot Can you contact me privately (see my profile for email)? I would like some help maintaining this library and I feel I am doing a disservice to you and the lib's users at this point. Simple reason is time. Am @randompunter on twitter too if you want to DM there. Cheers.

@snakefoot

This comment has been minimized.

Copy link
Contributor Author

snakefoot commented Nov 8, 2018

@snakefoot

This comment has been minimized.

Copy link
Contributor Author

snakefoot commented Nov 8, 2018

@damianh

This comment has been minimized.

Copy link
Owner

damianh commented Nov 8, 2018

I'm already fully booked with NLog so not ready for an extra child :)

Understood! thanks

@snakefoot

This comment has been minimized.

Copy link
Contributor Author

snakefoot commented Nov 8, 2018

@damianh Created #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.