Skip to content

Damian M. R. damianmr

Organizations

Zauber
Damian M. R.
Damian M. R.
Damian M. R.
damianmr commented on issue desandro/isotope#295
Damian M. R.

Thanks @fk, I'll try yours if this one does not work https://github.com/khiltd/isotope-leak-free/blob/master/jquery.isotope.js @desandro I am sorry…

damianmr commented on issue desandro/isotope#295
Damian M. R.

Anyway, in my opinion this is a bug that renders the plugin unusable and you should try to think of a solution for people who bought your software.…

damianmr commented on issue desandro/isotope#295
Damian M. R.

Found this thread on Google after searching "isotope memory leak" once I was totally sure that my code wasn't leaking. My case is that I am appendi…

Damian M. R.

BTW, Steven, you are writing/generating the same file that you are using as template. Is that on purpose or you just missed that? After the first s…

Damian M. R.

Ah, thanks! Now I see the problem is that your Grunt version does not have the custom delimiters feature. I am not sure if @mathiasbynens released …

Damian M. R.

Hi, I don't see why JavaScript files could be a problem. In fact, the tests for this feature are ".js" files. What I don't get in the example you p…

damianmr commented on pull request mathiasbynens/grunt-template#3
Damian M. R.

I added the tests that you suggested. Let me know if something else is missing. Thanks

Damian M. R.
  • Damian M. R. 9cadf97
    Adding two tests to the 'custom delimiters' feature.
damianmr commented on pull request mathiasbynens/grunt-template#3
Damian M. R.

Sure, I'll add them later.

damianmr commented on pull request mathiasbynens/grunt-template#3
Damian M. R.

@mathiasbynens done with your suggestions. Turns out the property is called "delimiters" (plural) so... "delimiters' name" :)

Damian M. R.
Damian M. R.
Adding support for custom delimiters.
1 commit with 60 additions and 8 deletions
Damian M. R.
  • Damian M. R. aaf4a36
    Adding support for custom delimiters. This is extremely useful if you…
damianmr commented on issue rubygems/rubygems.org#511
Damian M. R.

May it be related with this other known issue? bundler/bundler#1450

damianmr commented on issue twitter/bootstrap#3091
Damian M. R.

@fat Just like @lookfirst said, the solution you suggested is impractical. I'm not even handling the Tab's click event. It looks clearly as a bug t…

Damian M. R. master is now e094416
Something went wrong with that request. Please try again.