New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prereqs #15

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Sep 17, 2017

The missing dependencies were found by using Test::Kwalitee::Extra. This tool also found that Apache2::Response was missing, however it was decided not to add this as a dependency as it implies that mod_perl also needs to be installed, and in order for mod_perl to be installed and tested, one needs to install Apache as well. This seemed too big a hurdle for users simply wanting to install and use the module, so it was left out. Also, the use of Apache2::Response is conditional on its availablity and a set up mod_perl environment, so it doesn't need to be added as a prerequisite.

paultcochrane added some commits Sep 17, 2017

Add missing dependency on BerkeleyDB
This was found by using `Test::Kwalitee::Extra`.
Add missing test dependencies
These were found by `Test::Kwalitee::Extra`.
@damil

This comment has been minimized.

Show comment
Hide comment
@damil

damil Sep 17, 2017

Owner

Hi Paul, thanks for being so active about improving Pod::POM::Web. I'll try to incorporate your pull requests in the next few days. Cheers, Laurent

Owner

damil commented Sep 17, 2017

Hi Paul, thanks for being so active about improving Pod::POM::Web. I'll try to incorporate your pull requests in the next few days. Cheers, Laurent

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Sep 18, 2017

Contributor

Hi Laurent, no stress! If there's anything in particular you would like me to do, just let me know. Cheers, Paul.

Contributor

paultcochrane commented Sep 18, 2017

Hi Laurent, no stress! If there's anything in particular you would like me to do, just let me know. Cheers, Paul.

@damil

This comment has been minimized.

Show comment
Hide comment
@damil

damil Sep 24, 2017

Owner

BerkeleyDB is a dependeny of Search::Indexer which is an optional addition to PPW; so it should not be in the dependencies.
About the HTTP::* dependencies in build_requires() : thanks, I'll keep those

Owner

damil commented Sep 24, 2017

BerkeleyDB is a dependeny of Search::Indexer which is an optional addition to PPW; so it should not be in the dependencies.
About the HTTP::* dependencies in build_requires() : thanks, I'll keep those

@damil damil closed this Sep 24, 2017

@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Sep 25, 2017

Contributor

Oops, yeah, you're right about the BerkeleyDB dep. Sorry about that.

Contributor

paultcochrane commented Sep 25, 2017

Oops, yeah, you're right about the BerkeleyDB dep. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment