New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add META.* files to repo #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Sep 16, 2017

Although these files are created automatically in the ./Build dist
step, having them in the repo saves unnecessary warnings from appearing
in the perl Build.PL step for testers and potential contributors.

I don't know how controversial a change this is for you, however I thought it might be a useful change for potential contributors and it removes potentially confusing warnings in automated build and test systems.

Add META.* files to repo
Although these files are created automatically in the `./Build dist`
step, having them in the repo saves unnecessary warnings from appearing
in the `perl Build.PL` step for testers and potential contributors.
@damil

This comment has been minimized.

Show comment
Hide comment
@damil

damil Sep 24, 2017

Owner

thanks for the suggestion, but some people recommend NOT putting meta.* files under version control
see http://www.perlmonks.org/?node_id=1009586:

What should be checked into version control?

My general rule is that if a file is automatically regenerated on a regular basis (e.g. META.yml is often automatically generated when packaging up the distribution) then it doesn't go into version control. Everything else does.

Owner

damil commented Sep 24, 2017

thanks for the suggestion, but some people recommend NOT putting meta.* files under version control
see http://www.perlmonks.org/?node_id=1009586:

What should be checked into version control?

My general rule is that if a file is automatically regenerated on a regular basis (e.g. META.yml is often automatically generated when packaging up the distribution) then it doesn't go into version control. Everything else does.

@damil damil closed this Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment