New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests to cover passing an object to parse() #1

Merged
merged 1 commit into from Feb 12, 2017

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented Feb 7, 2017

The _flatten_into_hashref method was not previously covered by the test suite. This PR extends t/00-base.t to do so by conditionally requiring CGI and then running each of the main block of tests a second time but passing the CGI object to parse() instead of an unblessed hashref.

Note that this would produce a warning with modern versions of CGI.pm without the setting of $CGI::LIST_CONTEXT_WARN to be zero, which itself then requires removal of the "once" warning. You can decide if you are happy with all this suppression but it seemed reasonable to me as a first cut.

As the plan was already calculated dynamically there seemed no need to use skip here.

This PR was provided as part of the CPAN PR Challenge.

@damil

This comment has been minimized.

Show comment
Hide comment
@damil

damil Feb 12, 2017

Owner

Thanks Pete for your contribution

Owner

damil commented Feb 12, 2017

Thanks Pete for your contribution

@damil damil closed this Feb 12, 2017

@damil damil reopened this Feb 12, 2017

@damil damil merged commit c325dcd into damil:master Feb 12, 2017

@openstrike openstrike deleted the openstrike:coverage branch Feb 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment