Expanding enums #35

Closed
vicmosin opened this Issue Nov 6, 2015 · 6 comments

Projects

None yet

2 participants

@damnhandy
Owner

Enums wouldn't be captured there, but here:

https://github.com/damnhandy/Handy-URI-Templates/blob/master/src/main/java/com/damnhandy/uri/template/UriTemplate.java#L609

The DefaultVarExploder should only be called when the type is not a primitive, CharSequence, Number, or Date type. I haven't tested enums, but there probably needs to be some thought into how they are handled.

@vicmosin
vicmosin commented Nov 6, 2015

So they are not)) it fails with The value must an object exception

@damnhandy
Owner

Clearly not tested :) I'll have a gander at this over the weekend.

@damnhandy damnhandy added this to the 2.1 milestone Nov 7, 2015
@damnhandy damnhandy added a commit that referenced this issue Nov 7, 2015
@damnhandy Fixes for issues #34 and #35 bc28394
@damnhandy
Owner

@vicmosin I'm really surprised that such an obvious bug took 4 years for someone to find it. Thanks for the report. A few minor tweaks and it's functional now. I've pushed a snapshot to Maven Central under version 2.1.0-SNAPSHOT Should have a release out by the end of the weekend.

@vicmosin
vicmosin commented Nov 8, 2015

Confirmed, 2.1.0-SNAPSHOT fixes the issue.
What about 2.0.5-SNAPSHOT described in docs?

@damnhandy
Owner

I'm going straight to 2.1. Should be posting that later today.

@damnhandy damnhandy closed this Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment