Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding enums #35

Closed
vicmosin opened this issue Nov 6, 2015 · 6 comments
Closed

Expanding enums #35

vicmosin opened this issue Nov 6, 2015 · 6 comments
Milestone

Comments

@damnhandy
Copy link
Owner

@damnhandy damnhandy commented Nov 6, 2015

Enums wouldn't be captured there, but here:

https://github.com/damnhandy/Handy-URI-Templates/blob/master/src/main/java/com/damnhandy/uri/template/UriTemplate.java#L609

The DefaultVarExploder should only be called when the type is not a primitive, CharSequence, Number, or Date type. I haven't tested enums, but there probably needs to be some thought into how they are handled.

@vicmosin
Copy link
Author

@vicmosin vicmosin commented Nov 6, 2015

So they are not)) it fails with The value must an object exception

@damnhandy
Copy link
Owner

@damnhandy damnhandy commented Nov 7, 2015

Clearly not tested :) I'll have a gander at this over the weekend.

@damnhandy damnhandy added this to the 2.1 milestone Nov 7, 2015
damnhandy added a commit that referenced this issue Nov 7, 2015
@damnhandy
Copy link
Owner

@damnhandy damnhandy commented Nov 7, 2015

@vicmosin I'm really surprised that such an obvious bug took 4 years for someone to find it. Thanks for the report. A few minor tweaks and it's functional now. I've pushed a snapshot to Maven Central under version 2.1.0-SNAPSHOT Should have a release out by the end of the weekend.

@vicmosin
Copy link
Author

@vicmosin vicmosin commented Nov 8, 2015

Confirmed, 2.1.0-SNAPSHOT fixes the issue.
What about 2.0.5-SNAPSHOT described in docs?

@damnhandy
Copy link
Owner

@damnhandy damnhandy commented Nov 8, 2015

I'm going straight to 2.1. Should be posting that later today.

@damnhandy damnhandy closed this Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.