Merge kimo fixes #28
Draft
Merge kimo fixes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rown. Ensure that setup and teardown are not run on suite setup or teardowns. Fix statistics for test summary.
Added spec name to context data for running test steps.
Kimo/testing context status
… but not return immediately
…t in ensure of run function of runner. Added skip_on_error to allow skipping a step if an error occured, separate from continue
markuspg
force-pushed
the
merge_kimo_fixes
branch
3 times, most recently
from
26a69a9
to
39c75fd
Compare
…o_fixes This merge mostly goes with the changes already done by markuspg. Since the logic changes were heavily inspired by kimo his branch is included for the purpose of documentation and crediting his work.
* add an additional :uninitialized state to STATUS_CODES * fix all RuboCop offenses * make test string better distinguishable (changes output formatting!)
This change is done so that this file is in line with the others.
Since basically all options except the parser are optional these were more misleading than helpful.
This is in line with the other exceptions defined by rutema.
This should be better than just silently discarding the inserted value.
markuspg
force-pushed
the
merge_kimo_fixes
branch
from
4536f76
to
bb4f4bd
Compare
markuspg
force-pushed
the
merge_kimo_fixes
branch
2 times, most recently
from
4e42d9a
to
4500a7b
Compare
|
Too many things at once in this PR. So, linters are good but sometimes not good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi damphyr,
we'd like to use rutema for a current project and merge the changes from the Zuehlke fork of rutema. Would it be possible to merge these and update the Ruby gem?
I tried to do the necessary steps and update the dependencies too.
Best,
markuspg