New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [MinimumPerl] plugin #6

Merged
merged 1 commit into from Feb 13, 2016

Conversation

Projects
None yet
2 participants
@davorg
Contributor

davorg commented Feb 13, 2016

Hi,

I got IO::Socket::TimeOut in the Pull Request Challenge this month. I haven't had time to look at the code in detail, but I noticed that you're losing a Kwalitee point by not including the minimum supported Perl version in META.yml. This (really simple) patch uses Dist::Zilla::Plugin::MinimumVersion to fix that.

Hopefully I'll have time to do more work on the module before the end of the month, but I wanted to get at least one PR sent in.

Cheers,

Dave...

@dams

This comment has been minimized.

Show comment
Hide comment
@dams

dams Feb 13, 2016

Owner

Wow, it's an honor, Dave :)
Merging and closing this. Feel free to poke me here or on IRC to discuss more about this dist, it could use some external pov and suggestions

Owner

dams commented Feb 13, 2016

Wow, it's an honor, Dave :)
Merging and closing this. Feel free to poke me here or on IRC to discuss more about this dist, it could use some external pov and suggestions

dams added a commit that referenced this pull request Feb 13, 2016

Merge pull request #6 from davorg/master
Add [MinimumPerl] plugin

@dams dams merged commit 835d7ae into dams:master Feb 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment