From ae346c3c385a89a1a1424cd94804b04934fa0a9c Mon Sep 17 00:00:00 2001 From: Tomas Doran Date: Wed, 16 Nov 2011 10:27:35 +0000 Subject: [PATCH] Fix undef warnings --- Changes | 4 ++++ lib/Log/Message/Structured/Stringify/Sprintf.pm | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index ae7a8db..21dfbfe 100644 --- a/Changes +++ b/Changes @@ -1,3 +1,7 @@ + - Fix Log::Message::Structured::Stringify::Sprintf warnings when values + in the sprintf string are undef. They are now literally printed as + 'undef' + 0.002 - Fix docs for Stringify::Sprintf diff --git a/lib/Log/Message/Structured/Stringify/Sprintf.pm b/lib/Log/Message/Structured/Stringify/Sprintf.pm index d5d95c5..68cd0d8 100644 --- a/lib/Log/Message/Structured/Stringify/Sprintf.pm +++ b/lib/Log/Message/Structured/Stringify/Sprintf.pm @@ -28,7 +28,7 @@ role { my $self = shift; # FIXME - Find the correct reader name rather than assuming # attribute name == accessor name. - sprintf($format_string, map { $self->$_ } @attributes); + sprintf($format_string, map { my $val = $self->$_; $val = 'undef' unless defined $val; $val } @attributes); }; };