Fix a few crashes on 1.9 #2335
Closed
Fix a few crashes on 1.9 #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some japanese user profiles are breaking the flatbuffer profile builder for some reason Changelog-Fixed: Fix pretty bad crash when building flatbuffer profiles Signed-off-by: William Casarin <jb55@jb55.com>
This fixes a reflection runtime error for our custom picker Signed-off-by: William Casarin <jb55@jb55.com>
Changelog-Fixed: Fix crash when adding duplicate mute items Signed-off-by: William Casarin <jb55@jb55.com>
Changelog-Fixed: Fix crash on profile page when there are profile updates Signed-off-by: William Casarin <jb55@jb55.com>
|
Went through and fixed a bunch more crashes |
Merged
| @@ -82,7 +82,7 @@ extern "C" { | |||
| * Note: some internal assertion will remain if disabled. | |||
| */ | |||
| #ifndef FLATCC_BUILDER_ASSERT_ON_ERROR | |||
| #define FLATCC_BUILDER_ASSERT_ON_ERROR 1 | |||
| #define FLATCC_BUILDER_ASSERT_ON_ERROR 0 | |||
There was a problem hiding this comment.
Have we ruled out the risk that the aforementioned errors could corrupt flatbuffer data and cause further issues down the line?
There was a problem hiding this comment.
it is handled here:
NdbProfile_parse_json_table(ctx, buf, buf + bufsiz, profile);
if (ctx->error)
return 0;
in ndbprofile_parse_json
There was a problem hiding this comment.
Nice!
Do we have similar guards around other flatbuffer objects like ndbnotes and such (given that this constant looks global)? If we do, then this LGTM
There was a problem hiding this comment.
The changes in this file LGTM
|
Closing in favor of #2336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some japanese user profiles are breaking the flatbuffer profile builder for some reason
Changelog-Fixed: Fix pretty bad crash when building flatbuffer profiles