Manually specify the number of values to unpack #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
table.unpack will often stop at the first nil value, meaning some event arguments may be discarded. By storing the number of arguments through table.pack, and then using that count when unpacking, we can ensure all values are returned/resumed with.
This can be seen by running the following script:
Without this patch it will print
foo 1. With it you getfoo 1 nil 2as expected. There was also an Ask a Pro issue with someone sending anilrednet message, resulting in the protocol beingnil.Note I haven't patched any of the rom files (such as
nsh) as that might be better left for their respective authors. I also haven't touched anything which deals with command line arguments - those should never benilanyway. I'm happy to change them too, should people wish.