Improving cable/wired modem interactions #227
Open
Conversation
67ab7d0
to
a3fbe1d
@Wojbie The two PRs solve very different problems, so it's probably better to keep them separate, and just rebase whichever one isn't merged. Speaking of which, @dan200 do you have any idea when you'd next be able to look at PRs? I realise you've been busy with Redirection (and had some serious wrist injuries), so no rush :). |
88eab44
to
b39d765
8efb971
to
8e1625b
- Cable and modem can be broken individually - Ray tracing will go through "holes" in the cable. - Pick block will determine which part you are looking at. - Selection box will only highlight the region you are looking at: modem or cable.
This allows us to render the cable "core", as was done pre-1.8.
8e1625b
to
fb6d65e
We now use a couple of functions which switch depending on axis or direction, and delegate to them
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…improved-cable Improving cable/wired modem interactions
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
Not sure how useful this is - people are far more likely to come across the CurseForge page than the GH one, but there's no harm I guess. Closes dan200#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is an attempt to give networking cables a more "multipart" feel, without actually implementing any multipart API. There are still some improvements which can be made, I'm just putting this up to gauge interest and get some thoughts on the current implementation.
Current changes
Potential improvements
Screenshots