Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving cable/wired modem interactions #227

Open
wants to merge 6 commits into
base: master
from

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented May 9, 2017

This is an attempt to give networking cables a more "multipart" feel, without actually implementing any multipart API. There are still some improvements which can be made, I'm just putting this up to gauge interest and get some thoughts on the current implementation.

Current changes

  • Cable and modem can be broken individually, without destroying the tile entity.
  • Ray tracing will go through "holes" in the cable.
  • Pick block will determine which part you are looking at, using that for the item.
  • Selection box will only highlight the element you are looking at (the modem or cable part).
  • Selection box "hugs" the cable more closely.
  • Make the model better emulate the 1.7.10 version, with a black core.
  • Correctly clear the peripheral ID in the event of the modem part breaking. Otherwise you can wrap a different peripheral type and preserve the ID.

Potential improvements

  • Improve the selection box rendering - it is currently rather complicated and it probably can be tidied up a little.

Screenshots

@SquidDev SquidDev changed the title [WIP] Improving cable/wired modem interactions Improving cable/wired modem interactions May 11, 2017
@SquidDev SquidDev force-pushed the SquidDev-CC:feature/improved-cable branch from 67ab7d0 to a3fbe1d May 13, 2017
@Wojbie
Copy link
Contributor

@Wojbie Wojbie commented Jun 14, 2017

I just realized this would merge conflict with #312. Would you mind if I redid #312 on your code and PR that changes into this?

@SquidDev
Copy link
Contributor Author

@SquidDev SquidDev commented Jun 14, 2017

@Wojbie The two PRs solve very different problems, so it's probably better to keep them separate, and just rebase whichever one isn't merged.

Speaking of which, @dan200 do you have any idea when you'd next be able to look at PRs? I realise you've been busy with Redirection (and had some serious wrist injuries), so no rush :).

@SquidDev SquidDev force-pushed the SquidDev-CC:feature/improved-cable branch from 88eab44 to b39d765 Sep 10, 2017
@SquidDev SquidDev force-pushed the SquidDev-CC:feature/improved-cable branch 2 times, most recently from 8efb971 to 8e1625b Sep 10, 2017
SquidDev added 5 commits May 9, 2017
 - Cable and modem can be broken individually
 - Ray tracing will go through "holes" in the cable.
 - Pick block will determine which part you are looking at.
 - Selection box will only highlight the region you are looking at:
   modem or cable.
This allows us to render the cable "core", as was done pre-1.8.
@SquidDev SquidDev force-pushed the SquidDev-CC:feature/improved-cable branch from 8e1625b to fb6d65e Oct 4, 2017
We now use a couple of functions which switch depending on axis or
direction, and delegate to them
ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
…improved-cable

Improving cable/wired modem interactions
ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
Not sure how useful this is - people are far more likely to come across
the CurseForge page than the GH one, but there's no harm I guess.

Closes dan200#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants