Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak shell program resolution slightly #402

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@SquidDev
Copy link
Contributor

SquidDev commented Aug 2, 2017

See #219 for a more detailed explanation and rational

  • Path containing / or \ are resolved relative to the current directory, rather than using the path. Paths starting with / still resolve relative to the root directory.
  • Shell completion will also include sub-directories of the current directory.
@Wojbie

This comment has been minimized.

Copy link
Contributor

Wojbie commented Aug 2, 2017

I don't think it currently works correctly.
Try this sequence of events:

cd rom
write/autocomplete to programs/time.lua

Expected result : runs time.lua
Got result: No such program

Worst thing is that it auto completed correctly.

@SquidDev SquidDev force-pushed the SquidDev-CC:feature/shell-resolution branch 2 times, most recently from 11d17f4 to 5df97e5 Aug 3, 2017

@SquidDev

This comment has been minimized.

Copy link
Contributor Author

SquidDev commented Aug 3, 2017

@Wojbie Apparently I failed to test execution from places which weren't the root directory, should be fixed now. Thanks for spotting it!

Tweak shell program resolution slightly
 - Path containing '/' or '\' are resolved relative to the current
   directory, rather than using the path. Paths starting with '/' still
   resolve relative to the root directory.
 - Shell completion will also include sub-directories of the current
   directory.

Closes #219

@SquidDev SquidDev force-pushed the SquidDev-CC:feature/shell-resolution branch from 5df97e5 to 4df92ff Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.