/ComputerCraft

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check to textutils.tabulate/pagedTabulate #412

Open
wants to merge 2 commits into
base: master
from

Conversation

Reviewers

@dan200 dan200

@BombBloke BombBloke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Wilma456 @dan200 @BombBloke
@Wilma456
Contributor

Wilma456 commented Aug 10, 2017

No description provided.

src/main/resources/assets/computercraft/lua/rom/apis/textutils.lua Outdated
@@ -122,6 +122,9 @@ local function tabulateCommon( bPaged, ... )
for n, t in ipairs( tAll ) do
if type(t) == "table" then
for n, sItem in pairs(t) do
if type( sItem ) ~= "number" and type( sItem ) ~= "string" then
error( "textutils.tabulate/pagedTabulate only allow strings and numbers in the table", 3 )
end

This comment has been minimized.

Sign in to view
Copy link
@dan200

dan200 Aug 27, 2017

Owner

Please only allow strings here, and format the error message more standardly.

This comment has been minimized.

Sign in to view
Copy link
@BombBloke

BombBloke Aug 27, 2017

Contributor

Why only strings, all of a sudden? What happened to "no breaking changes"?

This comment has been minimized.

Sign in to view
Copy link
@Wilma456

Wilma456 Aug 31, 2017

Contributor

What should the message look like? e.g bad argument #Position.Position in Table (expected string, got foo)?
@Wilma456

This comment has been minimized.

Sign in to view
Contributor

Wilma456 commented Sep 12, 2017

@dan200 Changes are now done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment