Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for Keywords in textutils.complete() #436

Open
wants to merge 1 commit into
base: master
from

Conversation

@JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Sep 6, 2017

At the moment, textutils.complete will not complete Keywords. But this PR add a 3rd Argument with allows to enable autocompletion with Keywords.

@Wojbie
Copy link
Contributor

@Wojbie Wojbie commented Sep 6, 2017

Could you provide use case for this addition?

@JakobDev
Copy link
Contributor Author

@JakobDev JakobDev commented Sep 6, 2017

Lua shell or edit

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Sep 6, 2017

@Wilma456 This doesn't appear to do what you want it to do. There are a couple of problems:

  • This reintroduces the do completing to dofile issue (which was previously fixed by 76a3562).
  • This won't complete keywords on the "global" level (so i will not complete to if).
  • If you have a field with a keyword (such as x = { ["if"] = 1 }) then x. will complete to x.if. However, this is a syntax error and so is probably not intentional behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.