Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Only instantiate ServerComputer on tile ticks #454

wants to merge 2 commits into
base: master
Choose a base branch


Copy link

@SquidDev SquidDev commented Sep 15, 2017

This implements a couple of the solutions proposed in #409 and #442. There are a couple of things to note:

  • Fixes #442 (whilst #453 also fixes it, I believe the two together form a more complete solution).
  • Appears to fix #409. I've been running this on Airwaves since the PR was created, and it seems to work.
  • Calling .getID() when the computer has no id will not allocate one. This is a regression from current behaviour, so it's worth discussing what the appropriate behaviour should be. This is pretty rare (it'll only ever happen within the first tick of a computer being placed), but should still be considered.

I'll remove the WIP mark once I've resolved the last point.

SquidDev added 2 commits Sep 12, 2017
Instead we create a ComputerProxy, which delegates methods to the
ServerComputer or TileComputerBase, depending on which one exists.
@SquidDev SquidDev force-pushed the SquidDev-CC:hotfix/lazy-computer-peripheral branch from fbbfe33 to 245085f Dec 1, 2017
ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019

[WIP] Only instantiate ServerComputer on tile ticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant