Looks good. A couple of things worth changing though:
There's also a couple of issues which will result in the advancements not loading correctly:
If you enter a world, you should get some diagnostic error messages detailing what problems there are. Fix those errors and rinse and repeat until everything's fixed. It's a painful business but sadly only the first error is displayed.
On a totally unrelated note:
The Recipes are autogenerated with the completion of /recipe. I don't know, if It works without _1, computercraft or minecraft. I think, I will wait for a comment of @dan200, if I should put everything in one advancement or add the upgrade Items as criteria.
I had worked on a shooting turtle, so my script generated a Advancement for it and had forget to remove it, because it exits on my Computer and I get no error.
I will look after he recipes tomorrow and then I will remove the Shooting Turtle Recipe.