/ComputerCraft

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple JEI integration #482

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SquidDev @thatcraniumguy
@SquidDev
Contributor

SquidDev commented Oct 25, 2017 •
edited

I know that mod integration is something that ComputerCraft normally steers clear of, but JEI is sufficiently ubiquitous that this is probably worth it.

JEI compares items simply by item name and damage value, ignoring NBT. This means many recipes do not function correctly. For instance, viewing the recipe of a Melee Turtle will display all upgrade recipes. This PR fixes this:

  • Pocket computers and turtles are distinguished by upgrades and computer family.
  • Disks are distinguished by colour.
  • Hide treasure disks from the item list

Note that this doesn't add anything "fancy", such as recipe handlers for turtle and pocket upgrades. This might be worth considering in the future.
@SquidDev
Add simple JEI integration 
 - Ensure pocket computers and turtles are distinguished by upgrades and
   computer family.
 - Ensure disks are distinguished by colour.
 - Hide treasure disks from the list
Loading status checks…
d9d025e
@thatcraniumguy

This comment has been minimized.

Sign in to view

thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment