Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map-like rendering for pocket computers #497

Open
wants to merge 1 commit into
base: master
from

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Dec 1, 2017

This has been a suggested feature for as long as pocket computers have been a thing, so I thought it'd be worth seeing what other people think.

All in all, it works pretty well though there are a couple of issues:

  • Text is near illegible when in the off-hand. I don't think this is too big an issue as I see this being used for more graphical readouts.
  • Pocket upgrades have the ability to interact with right clicks. This may be less intuitive when rendering items like this.
  • The aspect ratio of the item's screen are different to the actual terminal's ratio. This means there is a wide margin to the left/right of the terminal. Rendering the background colour to the edge is even uglier, so I think we'd have to leave as is.

Despite that, I feel it works pretty well. Tragically you can't interact with it whilst in item form, but it's still pretty neat.

Screenshots

Shows this in action

Rendering in the offhand

The image was meant to say "Hai!" but I dropped a letter. Sorry.

@Restioson
Copy link
Contributor

@Restioson Restioson commented Dec 1, 2017

Really great!! So much more stuff will be possible if this is merged... Kudos! Just one question - how does one get it into map-like form (keybind)?

@SquidDev
Copy link
Contributor Author

@SquidDev SquidDev commented Dec 1, 2017

Just one question - how does one get it into map-like form (keybind)?

It's like that by default. It would be possible to add a config option/keybind/per-computer setting but I'm not sure how user-friendly that is.

@thatcraniumguy
Copy link

@thatcraniumguy thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?

ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
…pocket-map

Add map-like rendering for pocket computers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants