Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix turtle speaker upgrade's missing texture #508
Conversation
SquidDev
added some commits
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
thatcraniumguy
commented
May 23, 2018
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SquidDev commentedJan 19, 2018
•
edited
There's two parts to this commit: a simple fix, and a more comprehensive fix. Feel free to cherry pick one as desired.
The simple fix (2e7302e) simply adds the speaker texture to the texture sprite. As of MinecraftForge/MinecraftForge@7892ca9 the texture will not be automatically detected as resources are only loaded once.
The more comprehensive fix (80b1170) will automatically extract textures from the upgrade models. This has the advantages that we don't need to register textures ourselves, and also allows resource pack makers to use different texture names for upgrades.