Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix turtle speaker upgrade's missing texture #508

Open
wants to merge 2 commits into
base: master
from

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Jan 19, 2018

There's two parts to this commit: a simple fix, and a more comprehensive fix. Feel free to cherry pick one as desired.

The simple fix (2e7302e) simply adds the speaker texture to the texture sprite. As of MinecraftForge/MinecraftForge@7892ca9 the texture will not be automatically detected as resources are only loaded once.

The more comprehensive fix (80b1170) will automatically extract textures from the upgrade models. This has the advantages that we don't need to register textures ourselves, and also allows resource pack makers to use different texture names for upgrades.

SquidDev added 2 commits Jan 19, 2018
The sprite was not registered into the atlas, meaning it rendered the
missing texture instead.
This ensures we will not get missing texture errors in the future, and
allows resource pack artists to use additional textures.
@thatcraniumguy
Copy link

@thatcraniumguy thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?

ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
…urtle-speaker-model

Fix turtle speaker upgrade's missing texture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.