New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent turtles moving beyond the world border #520

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@SquidDev
Contributor

SquidDev commented Feb 12, 2018

As tiles outside the world border are not ticked, turtles are rendered entirely useless. Furthermore, the turtle animation will never progress resulting in visual glitches.

In order to avoid this, we ensure the target position is within the world border when moving to it.

Prevent turtles moving beyond the world border
As tiles outside the world border are not ticked, turtles are rendered
entirely useless. Furthermore, the turtle animation will never progress
resulting in visual glitches.

In order to avoid this, we ensure the target position is within the
world border when moving to it.
@@ -14,9 +14,9 @@
import dan200.computercraft.shared.util.WorldUtil;
import net.minecraft.block.Block;
import net.minecraft.entity.Entity;
import net.minecraft.util.EnumFacing;

This comment has been minimized.

@lupus590

lupus590 Feb 12, 2018

Contributor

Why was this line moved? I assume the move has no effect and just makes the commit a bit messy.

This comment has been minimized.

@SquidDev

SquidDev Feb 12, 2018

Contributor

Because my IDE likes to put things in alphabetical order. I'm going to be honest, I can't really muster the energy to fix it.

@thatcraniumguy

This comment has been minimized.

thatcraniumguy commented May 23, 2018

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment