Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent turtles moving beyond the world border #520
Conversation
| @@ -14,9 +14,9 @@ | ||
| import dan200.computercraft.shared.util.WorldUtil; | ||
| import net.minecraft.block.Block; | ||
| import net.minecraft.entity.Entity; | ||
| import net.minecraft.util.EnumFacing; |
This comment has been minimized.
This comment has been minimized.
lupus590
Feb 12, 2018
Contributor
Why was this line moved? I assume the move has no effect and just makes the commit a bit messy.
This comment has been minimized.
This comment has been minimized.
SquidDev
Feb 12, 2018
Contributor
Because my IDE likes to put things in alphabetical order. I'm going to be honest, I can't really muster the energy to fix it.
This comment has been minimized.
This comment has been minimized.
thatcraniumguy
commented
May 23, 2018
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SquidDev commentedFeb 12, 2018
As tiles outside the world border are not ticked, turtles are rendered entirely useless. Furthermore, the turtle animation will never progress resulting in visual glitches.
In order to avoid this, we ensure the target position is within the world border when moving to it.