Make the arguments of os.epoch, time and day case-insensitive #537
+3
−3
Conversation
It might be worth doing |
Also if there is any reason to keep the arguments case-sensitive I would suggest to at least allow "UTC" and "utc" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I don't see any reasons why the arguments of os.epoch should be case-sensitive.
This could be a problem especially with UTC when people try
os.epoch("UTC")
, but I think it would also make sense for "local" and "ingame" to be checked case-insensitive.