Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add additional method stubs to the TurtlePlayer #540
Forge's default fake player implementation doesn't override all methods which use the connection. As it is not set, we get an NPE and thus crash the server. We simply stub those methods out ourselves to prevent such an issue.
I'm going to look into submitting a similar PR into Forge, but it's worth adding it here first.
@JasonTheKitten Because they really shouldn't be needed - ideally these methods would be stubbed in Forge instead. The alternative would be to do what Plethora does and provide a "fake" connection, which just voids all packets.
I suspect it's not been done before as nobody has encountered such issues and thus a fix has not been needed.