New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound on how many bytes/characters can be read #541

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@SquidDev
Contributor

SquidDev commented Apr 23, 2018

The limit was added to prevent people creating arbitrarily large buffers (for instance, handle.read(2^31) would create a 2GB char array). For "large" counts, we now read in blocks of size 8192, adding to an extendable buffer.

See also SquidDev-CC/CC-Tweaked#29

Remove upper bound on how many bytes/characters can be read
The limit was added to prevent people creating arbitrarily large buffers
(for instance, handle.read(2^31) would create a 2GB char array). For
"large" counts, we now read in blocks of size 8192, adding to an
extendable buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment