New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of small improvements to CraftOS #566

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@SquidDev
Contributor

SquidDev commented Aug 12, 2018

  • Make window.reposition's argument validation a little more strict. Previously it would accept window.reposition(x, y, width) (no height argument), just not act upon it.
  • Use select instead of table.unpack within pastebin run.
  • Use parallel.waitForAny instead of waitForAll within the dance program.
  • Pipe the entire help file into textutils.pagedPrint, rather than doing it line by line.
  • Remove bytecode loading disabling from bios.lua. This never worked correctly, and serves little purpose as LuaJ is not vulnerable to such exploits.

I realise many of these changes are incredibly minor, and so don't really seem worth it. However, CraftOS is a great reference to link people to when they're looking for help, and so it's always good if we can show "best practices" for using CC & Lua's features.


If anyone else has changes that really aren't worth a separate PR, feel free to let me know/send a patch.

A couple of small improvements to CraftOS
 - Make window.reposition's argument validation a little more strict.
   Previously it would accept `window.reposition(x, y, width)` (no
   height argument), just not act upon it.
 - Use select instead of table.unpack within `pastebin run`.
 - Use `parallel.waitForAny` instead of `waitForAll` within the dance
   program.
 - Pipe the entire help file into `textutils.pagedPrint`, rather than
   doing it line by line.
 - Remove bytecode loading disabling from bios.lua. This never worked
   correctly, and serves little purpose as LuaJ is not vulnerable to
   such exploits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment