New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multiple comment notifications into one #145

Open
danbartlett opened this Issue Aug 5, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@danbartlett
Owner

danbartlett commented Aug 5, 2014

When comments get busy at the moment you get a lot of separate notifications.

Suggestion: When a new comment notification comes through, it should check to see whether the previous notification for the user was also a comment on the same thread, and merge them into one, and so on.

Same for likes.

@johnthepink

This comment has been minimized.

Show comment
Hide comment
@johnthepink

johnthepink Dec 19, 2014

Contributor

Like notifications should be easy enough to combine. Since comment notifications have different messaging depending on who commented on what, how do you envision that combining?

Contributor

johnthepink commented Dec 19, 2014

Like notifications should be easy enough to combine. Since comment notifications have different messaging depending on who commented on what, how do you envision that combining?

@danbartlett

This comment has been minimized.

Show comment
Hide comment
@danbartlett

danbartlett Dec 19, 2014

Owner

Good point. To start with I would just try compacting the Like notifications like this:

'dan liked your sit' -> 'tim and 1 other person liked your sit' -> 'gina and 2 other people liked your sit'

We could do the same with following notifications but I think it's better they stay separate at the moment, as it's important to emphasise new relationships. Comments I need to think more on but feel free to suggest something.

Owner

danbartlett commented Dec 19, 2014

Good point. To start with I would just try compacting the Like notifications like this:

'dan liked your sit' -> 'tim and 1 other person liked your sit' -> 'gina and 2 other people liked your sit'

We could do the same with following notifications but I think it's better they stay separate at the moment, as it's important to emphasise new relationships. Comments I need to think more on but feel free to suggest something.

@johnthepink

This comment has been minimized.

Show comment
Hide comment
@johnthepink

johnthepink Dec 19, 2014

Contributor

Cool, I'll take a shot at the likes for now, and think some on a good way to combine the comments. We could do the same thing as the likes, there's just a lot more cases involved. Seems like there should be a clean way to do it.

Contributor

johnthepink commented Dec 19, 2014

Cool, I'll take a shot at the likes for now, and think some on a good way to combine the comments. We could do the same thing as the likes, there's just a lot more cases involved. Seems like there should be a clean way to do it.

johnthepink added a commit to johnthepink/opensit that referenced this issue Dec 19, 2014

johnthepink added a commit to johnthepink/opensit that referenced this issue Jan 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment