Dan Beam
danbeam

Jun 28, 2016
@danbeam
Jun 28, 2016
@danbeam
Jun 22, 2016
danbeam commented on pull request PolymerElements/paper-ripple#86
@danbeam

can we just cast for this one thing? var keyEventTarget = /** @type {!EventTarget} */(this.keyEventTarget); this.listen(keyEventTarget, ...);

Jun 22, 2016
danbeam commented on pull request PolymerElements/paper-ripple#86
@danbeam

how would parentNode be null if this code runs in attached()? if it's inserted into an orphan DocumentFragment?

Jun 22, 2016
@danbeam
  • @danbeam 1242939
    Update outer-dimensions.js
Jun 22, 2016
@danbeam
Jun 22, 2016
danbeam merged pull request danbeam/outer-dimensions#1
@danbeam
Just some comment suggestions
2 commits with 12 additions and 2 deletions
Jun 22, 2016
danbeam commented on pull request danbeam/outer-dimensions#1
@danbeam

fyi: I think you meant {{height: number, width: number}}

Jun 22, 2016
@danbeam
Jun 22, 2016
@danbeam
Jun 22, 2016
@danbeam
Jun 22, 2016
@danbeam
Jun 22, 2016
danbeam created repository danbeam/outer-dimensions
Jun 22, 2016
Jun 21, 2016
@danbeam

nit: @type {?EventTarget} to make it clearer it can (and will) be null in some cases

Jun 21, 2016
@danbeam

shouldn't this technically say "The EventTarget that will be ...". is it valid to set this to document or window (which aren't HTMLElements but are E…

Jun 21, 2016
@danbeam
suppress internally used, deprecated offset properties
1 commit with 1 addition and 0 deletions
Jun 21, 2016
@danbeam
  • @danbeam 6b4182a
    suppress internally used, deprecated offset properties
Jun 21, 2016
@danbeam

for what it's worth, changing the @type of IronA11yKeysBehavior#keyEventTarget helps, but: if this.keyEventTarget CAN'T be null the = null assign…

Jun 21, 2016
@danbeam
  • @danbeam fe7571e
    Update iron-a11y-keys-behavior.html
Jun 21, 2016
@danbeam

Done. (removed cast)

Jun 21, 2016
@danbeam
  • @danbeam 7997fb0
    Update iron-overlay-manager.html
Jun 21, 2016
danbeam commented on commit Polymer/polymer@4616576efe
@danbeam

FYI: if I'm reading the code correctly, listen() could [semi-validly?] be called with target === null here, which would cause this to throw with Un…

Jun 21, 2016
@danbeam

i understand this was probably just a revert, but it fails to compile under stricter closure flags: https://build.chromium.org/p/tryserver.chromium…

Jun 20, 2016
@danbeam

if it was working, why would I need to send you a pull request? 😉 with the cast, chrome's code still fails to compile like this: ## /chromium/src/…

Jun 20, 2016
@danbeam
sprinkle some @suppress {missingProperties} for closure compilation
1 commit with 2 additions and 0 deletions
Jun 20, 2016
@danbeam