New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for crate evaluation #38

Open
sfackler opened this Issue May 7, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Jun 3, 2017

@danburkert "Add examples" can be checked.

brson commented Jun 3, 2017

@danburkert "Add examples" can be checked.

@killercup killercup referenced this issue Aug 1, 2017

Closed

August 2017 #35

10 of 10 tasks complete
@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Sep 22, 2017

Based on #46 and #31 it looks like we could use someone with familiarity, or at least ready access to, Windows to help get memmap over the line.

@danburkert would it be helpful if someone pulled the PR in #46 and spent some time poking it on Windows to fix the test failure?

KodrAus commented Sep 22, 2017

Based on #46 and #31 it looks like we could use someone with familiarity, or at least ready access to, Windows to help get memmap over the line.

@danburkert would it be helpful if someone pulled the PR in #46 and spent some time poking it on Windows to fix the test failure?

@zachmse

This comment has been minimized.

Show comment
Hide comment
@zachmse

zachmse Sep 25, 2017

@KodrAus @danburkert I can help poke around in PR #46. I got my windows environment setup last night and was able to reproduce the failure. I am still fairly new to Rust and haven’t done much windows-specific development, but if you would like an extra set of eyes I am more than happy to help.

zachmse commented Sep 25, 2017

@KodrAus @danburkert I can help poke around in PR #46. I got my windows environment setup last night and was able to reproduce the failure. I am still fairly new to Rust and haven’t done much windows-specific development, but if you would like an extra set of eyes I am more than happy to help.

@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Sep 25, 2017

Thanks @bjnyfv! I'm not 100% sure whether @danburkert has more they want to do with that PR, but if you're able to produce a fix that gets the build green then opening up a new PR and noting that it's based on #46 would probably be helpful.

Thanks again!

KodrAus commented Sep 25, 2017

Thanks @bjnyfv! I'm not 100% sure whether @danburkert has more they want to do with that PR, but if you're able to produce a fix that gets the build green then opening up a new PR and noting that it's based on #46 would probably be helpful.

Thanks again!

@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Sep 25, 2017

@bjnyfv if you'd like a sounding board anytime for any blitz work, please join on the Gitter channel. I haven't done much Windows native dev either, but will try help where I can.

KodrAus commented Sep 25, 2017

@bjnyfv if you'd like a sounding board anytime for any blitz work, please join on the Gitter channel. I haven't done much Windows native dev either, but will try help where I can.

@zachmse

This comment has been minimized.

Show comment
Hide comment
@zachmse

zachmse Sep 25, 2017

Thank you for the heads-up @KodrAus! I checked out the Gitter channel as suggested and noticed that @toankitsingh also mentioned helping out with the Windows issues. Perhaps @toankitsing and I can touch base if he is reading this. (I will also post a message in Gitter for him to hopefully see).

zachmse commented Sep 25, 2017

Thank you for the heads-up @KodrAus! I checked out the Gitter channel as suggested and noticed that @toankitsingh also mentioned helping out with the Windows issues. Perhaps @toankitsing and I can touch base if he is reading this. (I will also post a message in Gitter for him to hopefully see).

@KodrAus

This comment has been minimized.

Show comment
Hide comment
@KodrAus

KodrAus Dec 1, 2017

Now that memmap is stable fully libz blitz'd we should be able to close this.

KodrAus commented Dec 1, 2017

Now that memmap is stable fully libz blitz'd we should be able to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment