Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFailures when building with rust 2018 #140
Comments
This comment has been minimized.
This comment has been minimized.
leeola
commented
Dec 31, 2018
|
Possibly related?
via 2018 version. After switching to nightly, this went away. .. though, I'm still running into import failures via #142 |
This comment has been minimized.
This comment has been minimized.
|
I've worked around this with: mod proto {
use prost_derive::{Enumeration, Message};
include!(concat!(env!("OUT_DIR"), "/proto.rs"));
} |
nrc
added a commit
to nrc/prost
that referenced
this issue
Feb 4, 2019
nrc
added a commit
to nrc/prost
that referenced
this issue
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SecurityInsanity commentedDec 11, 2018
Enabling rust 2018 on a prost project will cause failures in certain generated messages. Specifically, those generated messages who end up generating modules. Specifically you might see error messages like:
Or maybe even some messages like:
These are caused by internal modules not including the types from:
prost_derive. (Specifically the generated macro types).All we should need is an: "use prost_derive::*" in these generated modules, however we probably want to also turn it into a feature for only 2018, so this crate doesn't force 2018 edition code on others. Or maybe since it's an include that just won't get used it's fine since it'll be optimized away?