Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing PHPUnit::execute Coverage Tags #1258

merged 2 commits into from
Dec 14, 2016


Copy link

Contribution Type: bug fix
Link to Bug:

This pull request affects the following areas:

In raising this pull request, I confirm the following (please check boxes):

  • [*] I have read and understood the contributing guidelines?
  • [*] I have checked that another pull request for this purpose does not exist.
  • [*] I have considered, and confirmed that this submission will be valuable to others.
  • [*] I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • [*] Do the PHPCI tests pass?

Detailed description of change:

Removed the @Covers PHPUnit::execute declaration - no such thing exists in the code and code coverage testing will not finish otherwise.

Fenikkusu and others added 2 commits September 2, 2016 09:33
Fixing Accidental Change To Code Standards
Copy link
Contributor Author

Note: While regular unit tests pass, I'm coming across a odd issue when running the code coverage testing. For what ever reason, BuildLoggerTest::testLogFailure_AddsExceptionContext will not complete if running all tests. If running just the single test, the test completes fine. I'm not sure what is going on here. The only thing I've noticed is an error in PHPStorm indicating an additional attempted connection failed.

@dancryer dancryer merged commit 99f4ef0 into dancryer:master Dec 14, 2016
@Fenikkusu Fenikkusu deleted the code-coverage-fixes branch December 14, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants