Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing PHPUnit::execute Coverage Tags #1258

Merged
merged 2 commits into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@Fenikkusu
Copy link
Contributor

Fenikkusu commented Sep 2, 2016

Contribution Type: bug fix
Link to Bug: https://github.com/Block8/PHPCI/issues/1250

This pull request affects the following areas:

In raising this pull request, I confirm the following (please check boxes):

  • [*] I have read and understood the contributing guidelines?
  • [*] I have checked that another pull request for this purpose does not exist.
  • [*] I have considered, and confirmed that this submission will be valuable to others.
  • [*] I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • [*] Do the PHPCI tests pass?

Detailed description of change:

Removed the @Covers PHPUnit::execute declaration - no such thing exists in the code and code coverage testing will not finish otherwise.

Fenikkusu added some commits Sep 2, 2016

PSR-4 Change
Fixing Accidental Change To Code Standards
@Fenikkusu

This comment has been minimized.

Copy link
Contributor Author

Fenikkusu commented Sep 2, 2016

Note: While regular unit tests pass, I'm coming across a odd issue when running the code coverage testing. For what ever reason, BuildLoggerTest::testLogFailure_AddsExceptionContext will not complete if running all tests. If running just the single test, the test completes fine. I'm not sure what is going on here. The only thing I've noticed is an error in PHPStorm indicating an additional attempted connection failed.

@dancryer dancryer merged commit 99f4ef0 into dancryer:master Dec 14, 2016

@Fenikkusu Fenikkusu deleted the twistersfury:code-coverage-fixes branch Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.