Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed useless link + fixed some css/js paths #1278

Closed
wants to merge 1 commit into from

Conversation

@corpsee
Copy link
Contributor

commented Oct 24, 2016

Contribution Type: cosmetic
Link to Intent to Implement: -
Link to Bug: -

This pull request affects the following areas:

  • Front-End
  • Builder
  • Build Plugins

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributing guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • Do the PHPCI tests pass?

Detailed description of change:
Removed useless link + fixed some css/js paths

@@ -18,7 +17,7 @@
<script src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script type="text/javascript" src="https://www.google.com/jsapi"></script>

<script src="<?php echo PHPCI_URL ?>assets/js/bootstrap.min.js"></script>
<script src="//cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.1/js/bootstrap.min.js"></script>

This comment has been minimized.

Copy link
@Shade634

Shade634 Oct 24, 2016

Personally, I am not a big fan of including externals in my CI software.

@dancryer

This comment has been minimized.

Copy link
Owner

commented Dec 14, 2016

As @Shade634 mentioned, a lot of people were not keen on there being externals here. I'd suggest we should be looking at removing all externals rather than adding new ones.

@dancryer dancryer closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.