Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rebuild on Git webhook #1346

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@mathysie
Copy link
Contributor

mathysie commented Nov 18, 2017

Enables for example a maintainer to run a daily build of their project,
whether a change has been made or not. The rebuild parameter is made
fully optional.

Contribution Type: new feature

This pull request affects the following areas:

  • Front-End
  • Builder
  • Build Plugins

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributing guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • Do the PHPCI tests pass?

Detailed description of change:

An optional parameter rebuild has been added to WebhookController::createBuild. This allows a maintainer to use the git webhook to start a rebuild of their project. At our project we want an automatic daily build of the project and this feature supports it.

In WebhookController::git the parameter rebuild can be read, where it is false if no parameter has been given. The parameter $rebuild is then passed to WebhookController::createBuild. There the parameter $rebuild is also made optional and false by default, such that other calls to createBuild are still supported.

Add support for rebuild on Git webhook
Enables for example a maintainer to run a daily build of their project,
whether a change has been made or not. The rebuild parameter is made
fully optional.

@dancryer dancryer merged commit 2b89233 into dancryer:master Jun 18, 2018

1 check failed

PHPCI PHPCI build failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.