Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex for parsing gitlab access informations #1351

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@gabrhel
Copy link

commented Feb 27, 2019

Contribution Type: bug fix
Link to Intent to Implement: none
Link to Bug: #1143

This pull request affects the following areas:

  • Front-End
  • Builder
  • Build Plugins

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributing guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I have created or updated the relevant documentation for this change on the PHPCI Wiki.
  • Do the PHPCI tests pass?

Detailed description of change:

  • changed regex for correct parse ports and vendors starting with number .
  • added 2 tests for parsing gitlab ssh address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.