Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filesystem #2

Closed
wants to merge 10 commits into from
Closed

Feature/filesystem #2

wants to merge 10 commits into from

Conversation

@gabriel403
Copy link
Contributor

@gabriel403 gabriel403 commented May 13, 2013

Reasonable first attempt at setting up a filesystem location for doing unit tests.
Also fixed the annoying favicon.ico error (by including an empty favicon).
Also fixed some indentation stuff that was really bugging me

Gabriel Baker added 5 commits May 13, 2013
Sorted out some indentation
Check if array etc
Fixes for phpunit
Current working directory in phpunit
php code coverage in composer.json
@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

Have marked this as WIP as I want to change the symlink part to something else, probably a cp or rsync with ability to do ignores for the rsync

@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

Hi @dancryer yeh I've fixed that in the latest revision
https://github.com/Block8/PHPCI/pull/2/files#L0R196

@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

I've tried a number of ways of cp-ing or rsync-ing instead of the symlink, but they're too damn slow, I think the symlink is the best option atm, do you have any other ideas @dancryer ?

@dancryer
Copy link
Owner

@dancryer dancryer commented May 14, 2013

I think I would be most comfortable with the idea of using cp -Rf, despite any related slowness, purely because a build can sometimes modify the working directory. Copying to a new directory means that the build can modify anything it wants, and then "clean up" by removing the files entirely.

@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

I tend to agree, I'll change it to a cp

@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

Hi @dancryer I've mad this optional with the latest commits, so if in the config you specifically tell it to symlink it will, otherwise it'll just cp -Rf

@dancryer
Copy link
Owner

@dancryer dancryer commented May 14, 2013

Nice! Is it ready to merge?

On Tuesday, 14 May 2013, Gabriel Baker wrote:

Hi @dancryer https://github.com/dancryer I've mad this optional with
the latest commits, so if in the config you specifically tell it to symlink
it will, otherwise it'll just cp -Rf


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-17892838
.

Dan Cryer

07590 698944
dan@dancryer.com
+Dan https://plus.google.com/101400775372325517263
@dancryer http://www.twitter.com/dancryer

@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 14, 2013

Yeh go for it :) I've also added a wiki page with a sample yml config file, hope that's ok

@dancryer
Copy link
Owner

@dancryer dancryer commented May 15, 2013

I've landed this. :)

It's worth noting that all of the "...Base.php" files are auto-generated, so there wasn't any benefit in modifying those I'm afraid.

@dancryer dancryer closed this May 15, 2013
@gabriel403
Copy link
Contributor Author

@gabriel403 gabriel403 commented May 15, 2013

Heh I was just rebasing it to include the yaml changes, but you beat me to it, awesome, I'll pull this and give a test, thanks.

@gabriel403 gabriel403 deleted the gabriel403:feature/filesystem branch May 15, 2013
dancryer added a commit that referenced this pull request Apr 16, 2014
Added database-based yml build config #2
meadsteve pushed a commit that referenced this pull request May 14, 2014
dancryer pushed a commit that referenced this pull request Oct 9, 2015
ptejada added a commit to ptejada/PHPCI that referenced this pull request Jan 6, 2017
prezire pushed a commit to prezire/PHPCI that referenced this pull request Feb 27, 2018
prezire pushed a commit to prezire/PHPCI that referenced this pull request Feb 27, 2018
prezire pushed a commit to prezire/PHPCI that referenced this pull request Feb 27, 2018
prezire pushed a commit to prezire/PHPCI that referenced this pull request Feb 27, 2018
dancryer pushed a commit that referenced this pull request Feb 27, 2019
dancryer pushed a commit that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants