New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 delta 0.4.5 binary release messes up terminal on Ubuntu 20 04
#463
Comments
I was able to reproduce it. |
Hi @MarcoIeni. Do you understand what's happening here? I was not able to reproduce this in a docker container. |
I tried with I will patiently go back commit by commit to identify where the problem started :) |
Thanks very much @MarcoIeni! I'm on MacOS (and can run in Docker also) and cannot reproduce, but I will try to think what might be going wrong. Here are some questions in case they help pinpoint the problem
|
Default ubuntu terminal emulator (gnome-terminal): works with zsh and doesn't work with bash.
no!
yes, both cases |
Interesting! What are your values of the |
OK, if you could determine the first bad commit that would be fantastic. |
It looks like the problem was introduced in 46eb84b Also, the problem does not appear if diffs are displayed with a pager ( Reproduction guide. Ubuntu 20.04, gnome terminal, bash: git clone https://github.com/dandavison/delta
cd delta
# the following command will revert to last working state
git checkout a632e3f704d8e5b10326f6d79ad58807f2fa103d
cargo build --release
./target/release/delta file1 file2
# now if you try to type something you should be able to see what you type
# the following command will go to the point where the problem was introduced
git checkout 46eb84bd34f8ff67f749eec8a287d5a3e7a0919a
cargo build --release
./target/release/delta file1 file2
# now if you try to type something you should NOT be able to see what you type @salmankhilji can you confirm my reprodution guide? |
Thanks @MarcoIeni, I think I can see that this is broken on MacOS, even though it isn't messing up my terminal: when I do I'm guessing I wrote some very bad process management code in 46eb84b and there's a race condition somewhere between |
Thanks very much for debugging @MarcoIeni! |
I am trying to find a solution as well, I don't get why it doesn't work <.< |
the problem is that you don't have to pass the writer variable to that function. I am trying to solve the problem against master and doing a PR. The problem is: that variable is required by tests |
This does not reproduce bug #463 (at least, not reliably).
0.5.0 was just released and contains the fix for this issue. Thanks very much @salmankhilji for reporting this with helpful detail. |
Release 0.4.5, when run on Ubuntu 20 04, messes up the terminal. After running
delta
, I see the diff output; however, any subsequent typing within the terminal is not echo'd back.As you can see, I intentionally typed a non-existant command
lll
, which is not echo'd back. Then I typed./delta --version
, which is also not echo'd back. The result of the command is, however, seen in the output above.The text was updated successfully, but these errors were encountered: