Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add end to end tests #400

Merged
merged 1 commit into from Nov 22, 2020
Merged

ci: add end to end tests #400

merged 1 commit into from Nov 22, 2020

Conversation

MarcoIeni
Copy link
Contributor

I left cargo test as it is instead of calling make test because in this way we use the actions-rs/cargo action instead of just calling cargo from the command line.
Main benefit of doing this:

Warnings and errors issued by cargo will be displayed in GitHub UI

dandavison
dandavison approved these changes Nov 22, 2020
View changes
Copy link
Owner

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dandavison dandavison merged commit 68498c4 into dandavison:master Nov 22, 2020
@dandavison
Copy link
Owner

Yes, thanks that sounds like the right way of doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoIeni @dandavison