Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load JAR resources via classpath #95

Open
jchafik opened this issue Sep 1, 2015 · 1 comment
Open

Load JAR resources via classpath #95

jchafik opened this issue Sep 1, 2015 · 1 comment

Comments

@jchafik
Copy link
Contributor

jchafik commented Sep 1, 2015

Currently, JarLocator converts the JAR location to a URL based on the client request URL. This is inefficient and introduces the possibility of other errors.

Additionally, when there is an error, JarLocator sets neverFail to true, forcing the request to silently fail.

A few issues with the current configuration:

  • The URL may be served on HTTPS. If SSL is misconfigured, Java is by default more intolerant than most clients. This can include an incomplete certificate chain or SNI issues.
  • Outbound traffic may be restricted by a firewall
  • An entire HTTP cycle is required to fetch an asset (longer if SSL is introduced), opposed to a few I/O operations on the filesystem otherwise.
@tduchateau
Copy link
Member

You're right! Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants