Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service to the announced ones #404

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@moikot
Copy link
Contributor

moikot commented Feb 21, 2019

Multiple services with the same IP address should be added to the list of the announced services no matter how many times the IP address is used.

What this PR does / why we need it:
This PR is fixing the issue when layer 2 ARP announcer function SetBalancer is called multiple times for several services sharing the same IP address. After adding the first service the following calls of SetBalancer with the same IP address increasing the IP address usage counter but do not add services to the list of the announced ones. This prevents DeleteBalancer from releasing the IP address when the services are not announced anymore.

Fixes #402

@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 21, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Add service to the announced ones
Multiple services with the same IP address should be added to the list of the announced services no matter how many times the IP address is used.
@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 21, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@danderson

This comment has been minimized.

Copy link
Owner

danderson commented Feb 28, 2019

Thanks!

@danderson danderson merged commit 7589ae0 into danderson:master Feb 28, 2019

3 checks passed

ci/circleci: test-1.11 Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
deploy/netlify Deploy preview ready!
Details
@moikot

This comment has been minimized.

Copy link
Contributor Author

moikot commented Mar 1, 2019

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.