baseline.target needs to be set before before baseline.setbase() is called. #10

Closed
wants to merge 3 commits into
from

Projects

None yet

1 participant

@mfields
mfields commented Aug 30, 2012

Testing the vanilla script I noticed that my images were not resizing. I discovered that baseline.newHeight was never being set because baseline.target was undefined. The best solution I found was to call baseline.tellmetarget() before baseline.setbase().

mfields added some commits Aug 30, 2012
@mfields mfields Set the value of this.target in init() before setBase() is called. f8e1840
@mfields mfields baseline.target needs to be set before before baseline.setbase() is c…
…alled:

 * Remove code that set baseline.target in init().
 * Call baseline.tellmetarget() before baseline.setbase().
a295ee2
@mfields mfields Remove quotes from the examples at the top of baseline.js. The second…
… parameter needs to be an int. Strings will not work.
77d97b9
@daneden daneden closed this in #19 Aug 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment