authenticate passing the current request to the backends that need it #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danfairs can you please give me feedback on this PR? thx! |
|
Looks fine, could you add a quick test to make sure that the request is being passed please? (Also, can I confirm that the tests don't pass with this change and the messages app added? I'm afraid I don't have a dev env right now to check it myself). Thanks! |
|
Just a heads-up: The changes in this PR are partly covered by #67, which was merged in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. https://django-axes.readthedocs.io/en/latest/3_usage.html#authenticating-users
Otherwise that will fail with AxesBackendRequestParameterRequired('AxesBackend requires a request as an argument to authenticate')