New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C visibility support #39

Merged
merged 9 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@j-rivero
Contributor

j-rivero commented Nov 9, 2017

This PR implements the control of binary symbols visibility in libccd.

The PR uses the cmake GenerateExportsHeader to provide the needed export header and change the visibility name to CCD_EXPORT.

The PR also adds the CCD_HIDE_ALL_SYMBOLS option (OFF by the default). This option covers a use case we found in Drake where a software uses ccd (linked statically) but does not expose it in the public API (headers). In this scenario the best option to avoid any possible conflict with other versions of fcl is to hide all the symbols from the public ABI.

I've tested this PR against the current fcl mastert branch.

@j-rivero

This comment has been minimized.

Show comment
Hide comment
@j-rivero

j-rivero Nov 9, 2017

Contributor

Looks like Travis supports not only the use of cmake but also the use of autotools and makefiles. Should I adapt the PR to work also with autotools or it is consider as a deprecated build system for libccd?

Contributor

j-rivero commented Nov 9, 2017

Looks like Travis supports not only the use of cmake but also the use of autotools and makefiles. Should I adapt the PR to work also with autotools or it is consider as a deprecated build system for libccd?

@jamiesnape jamiesnape referenced this pull request Nov 9, 2017

Closed

Resolving system dependency conflicts (meta) #7412

15 of 17 tasks complete
@danfis

This comment has been minimized.

Show comment
Hide comment
@danfis

danfis Nov 14, 2017

Owner

Thanks for the patch.

Regarding the autotools, I am not sure, but I think some people still use it, so I would rather keep it.

Owner

danfis commented Nov 14, 2017

Thanks for the patch.

Regarding the autotools, I am not sure, but I think some people still use it, so I would rather keep it.

@danfis danfis merged commit 5677d38 into danfis:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment