From 76b7bb19f5a0afc8ec7999f832ea237ecd784934 Mon Sep 17 00:00:00 2001 From: Kraig Amador Date: Mon, 8 Apr 2019 17:13:39 -0700 Subject: [PATCH] Fixes inline commenting in GitLab --- source/dsl/GitLabDSL.ts | 4 ++-- source/platforms/GitLab.ts | 2 +- source/platforms/gitlab/GitLabAPI.ts | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/source/dsl/GitLabDSL.ts b/source/dsl/GitLabDSL.ts index 32d8678bf..cfef39f1a 100644 --- a/source/dsl/GitLabDSL.ts +++ b/source/dsl/GitLabDSL.ts @@ -185,9 +185,9 @@ export interface GitLabDiscussionTextPosition { start_sha: string head_sha: string new_path: string - new_line: string + new_line: number old_path: string - old_line: string | null + old_line: number | null } export interface GitLabInlineNote extends GitLabNote { diff --git a/source/platforms/GitLab.ts b/source/platforms/GitLab.ts index 3a7980153..b7a5c0ab5 100644 --- a/source/platforms/GitLab.ts +++ b/source/platforms/GitLab.ts @@ -158,7 +158,7 @@ class GitLab implements Platform { old_path: path, old_line: null, new_path: path, - new_line: `${line}`, + new_line: line, }) } diff --git a/source/platforms/gitlab/GitLabAPI.ts b/source/platforms/gitlab/GitLabAPI.ts index 3fc5edd31..afd3e08a9 100644 --- a/source/platforms/gitlab/GitLabAPI.ts +++ b/source/platforms/gitlab/GitLabAPI.ts @@ -1,14 +1,14 @@ import { RepoMetaData } from "../../dsl/BitBucketServerDSL" import { api as fetch } from "../../api/fetch" import { + GitLabDiscussionTextPosition, + GitLabInlineNote, GitLabMR, - GitLabMRChanges, GitLabMRChange, + GitLabMRChanges, GitLabMRCommit, - GitLabUserProfile, - GitLabInlineNote, GitLabNote, - GitLabDiscussionTextPosition, + GitLabUserProfile, } from "../../dsl/GitLabDSL" import { Gitlab } from "gitlab" @@ -126,7 +126,7 @@ class GitLabAPI { try { const res = await api.create(this.repoMetadata.repoSlug, this.repoMetadata.pullRequestID, content, { - position, + position: position, }) return res