Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a comprehensive snapshot test for the github DSL #164

Closed
orta opened this issue Mar 13, 2017 · 2 comments
Closed

Make a comprehensive snapshot test for the github DSL #164

orta opened this issue Mar 13, 2017 · 2 comments
Labels
enhancement help wanted You Can Do This This idea is well spec'd and ready for a PR

Comments

@orta
Copy link
Member

orta commented Mar 13, 2017

When I added some more DSL attributes to the github DSL, CI was still green.

We probably need something to test using the fixtured data from GitHub ( see GitHub.tests.ts ) to make an entire DSL that we can run a snapshot against.
@orta orta added enhancement help wanted You Can Do This This idea is well spec'd and ready for a PR labels Mar 13, 2017
@orta orta mentioned this issue Mar 13, 2017
Merged
@orta orta changed the title Make a comprehensive test for the github DSL Make a comprehensive snapshot test for the github DSL Mar 19, 2017
@orta
Copy link
Member Author

orta commented Mar 30, 2017

I added a few more of the requests into figures, this should be feasible now

@orta
Copy link
Member Author

orta commented Sep 21, 2018

This is in now.

@orta orta closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted You Can Do This This idea is well spec'd and ready for a PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta