/danger-js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local mode don't work without credentials #767

Closed
langovoi opened this Issue Nov 15, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@langovoi @orta
@langovoi
Contributor

langovoi commented Nov 15, 2018 •
edited

When I try to use danger local without BitBucket or GitHub credentials i got error on this line

The DANGER_GITHUB_API_TOKEN/DANGER_BITBUCKETSERVER_HOST environmental variable is missing

@langovoi langovoi changed the title from `local` don't work without credentials to local mode don't work without credentials Nov 15, 2018

@orta

This comment has been minimized.

Sign in to view
Member

orta commented Nov 15, 2018

Ah yeah, this is likely an oversight because I have DANGER_GITHUB_API_TOKEN in my ENV, it should be passing in the FakeCI env vars from the command

@orta orta referenced this issue Nov 20, 2018

Merged

Allow sub-processes to request DSL JSON #769

@langovoi langovoi closed this Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment