Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options 'newComment' and 'removePreviousComments' #1096

Merged
merged 4 commits into from
Jan 4, 2021
Merged

add options 'newComment' and 'removePreviousComments' #1096

merged 4 commits into from
Jan 4, 2021

Conversation

davidhouweling
Copy link
Contributor

This PR adds options newComment and removePreviousComments.

This is [very loosely] based on the options available in the Ruby implementation.

This PR resolves #547.

Note to reviewers, would be good to sanity check that this the implementation is as expected as I simply did the code change purely based on what I thought the description of the options implied.

@orta
Copy link
Member

orta commented Dec 26, 2020

I will give this a second look later, but as far as I remember - this works like I'd expect from the ruby implementation and I'm on-board with the changes 👍🏻

Nice one

@orta
Copy link
Member

orta commented Jan 4, 2021

Thanks for your patience, yeah, this acts similar to how the ruby version works to me 👍🏻

@orta orta merged commit a461e43 into danger:master Jan 4, 2021
@davidhouweling davidhouweling deleted the feat/547-delete-new-comment branch January 4, 2021 22:21
@orta
Copy link
Member

orta commented Jan 4, 2021

Shipped in 10.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BitBucketServer] Always updates the comment
2 participants